mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38577: Added synchronous validation for Call in Agent
Date Wed, 30 Sep 2015 05:27:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review101078
-----------------------------------------------------------


Thanks Isabel, this looks pretty neat now. Just some minor cleanup comments.


src/slave/validation.cpp (line 58)
<https://reviews.apache.org/r/38577/#comment158396>

    Nit: const TaskStatus& status = call.update().status();



src/slave/validation.cpp (line 65)
<https://reviews.apache.org/r/38577/#comment158399>

    s/in Update/in TaskStatus



src/slave/validation.cpp (lines 70 - 77)
<https://reviews.apache.org/r/38577/#comment158397>

    Should we be explicitly validating that the source is always SOURCE_EXECUTOR i.e. something
like ?
    
    if (state.source() != TaskStatus::SOURCE_EXECUTOR) {
    // Failed Validation
    }
    
    ...
    
    if (status.state() == TASK_STAGING) {
    // Failed Validation
    }


- Anand Mazumdar


On Sept. 29, 2015, 9:25 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 9:25 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 891f951 
>   src/Makefile.am 8aa4566 
>   src/slave/http.cpp f9cf7bb 
>   src/slave/validation.hpp PRE-CREATION 
>   src/slave/validation.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38577/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message