mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38452: Updated C++ style guide for namespace usage
Date Tue, 29 Sep 2015 22:53:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review101038
-----------------------------------------------------------



docs/mesos-c++-style-guide.md (lines 41 - 43)
<https://reviews.apache.org/r/38452/#comment158342>

    It looks like we should mirror the structure of Google's C++ style guide here to make
the differences more clear.
    
    So these belong in: 'Scoping' -> 'Namespaces'
    
    See: http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
    
    Can you add a 'Scoping' section above and have 'Namespaces' as the subsection with the
content you've added here?


- Ben Mahler


On Sept. 24, 2015, 2:20 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 2:20 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message