mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilbert Song" <gilb...@mesoshere.io>
Subject Re: Review Request 38747: Adding digest utilities
Date Mon, 28 Sep 2015 18:43:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/#review100839
-----------------------------------------------------------



3rdparty/libprocess/include/process/digest.hpp (lines 210 - 226)
<https://reviews.apache.org/r/38747/#comment158093>

    digest printed out is different between digest(const char* bytes, size_t size) and digest(const
std::string& filePath) with a corresponding same string. 
    
    Logic check is needed. (proprably is a logical error in my test case)



3rdparty/libprocess/include/process/digest.hpp (line 275)
<https://reviews.apache.org/r/38747/#comment158090>

    This line is supposed to be deleted.


- Gilbert Song


On Sept. 25, 2015, 8:33 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38747/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added SHA256, SHA512 implementation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
>   3rdparty/libprocess/include/Makefile.am fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
>   3rdparty/libprocess/include/process/digest.hpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/CMakeLists.txt a14b5b8fe22d3e75bef3c716ae7865ddaf132927

>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38747/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message