mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 38747: Adding digest utilities
Date Mon, 28 Sep 2015 18:32:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/#review100835
-----------------------------------------------------------



3rdparty/libprocess/include/process/digest.hpp (line 191)
<https://reviews.apache.org/r/38747/#comment158087>

    I believe this leaks "fd".



3rdparty/libprocess/include/process/digest.hpp (line 205)
<https://reviews.apache.org/r/38747/#comment158086>

    Probably "constexpr" is better than "static const".



3rdparty/libprocess/include/process/digest.hpp (line 219)
<https://reviews.apache.org/r/38747/#comment158088>

    Seems like this duplicates some code above: can we refactor this into a function?



3rdparty/libprocess/include/process/digest.hpp (line 222)
<https://reviews.apache.org/r/38747/#comment158084>

    Why do we initialize this to `{0}`?



3rdparty/libprocess/include/process/digest.hpp (line 225)
<https://reviews.apache.org/r/38747/#comment158085>

    Need a space after "for".
    
    Also, is sprintf() really the best choice here? There's std::hex + std::stringstream,
although maybe that's not better overall.



3rdparty/libprocess/include/process/digest.hpp (line 237)
<https://reviews.apache.org/r/38747/#comment158081>

    Typo



3rdparty/libprocess/include/process/digest.hpp (line 265)
<https://reviews.apache.org/r/38747/#comment158083>

    Typo



3rdparty/libprocess/include/process/digest.hpp (line 315)
<https://reviews.apache.org/r/38747/#comment158082>

    Typo


- Neil Conway


On Sept. 25, 2015, 8:33 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38747/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added SHA256, SHA512 implementation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
>   3rdparty/libprocess/include/Makefile.am fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
>   3rdparty/libprocess/include/process/digest.hpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/CMakeLists.txt a14b5b8fe22d3e75bef3c716ae7865ddaf132927

>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38747/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message