mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).
Date Mon, 28 Sep 2015 17:42:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review100823
-----------------------------------------------------------

Ship it!



support/apply-reviews.py (line 8)
<https://reviews.apache.org/r/38705/#comment158071>

    Not used.



support/apply-reviews.py (line 12)
<https://reviews.apache.org/r/38705/#comment158069>

    Typo: Retutns.
    
    Also, docstrings go inside the method body.
    
    ```
    def review_url(id):
      """Returns a Review Board URL given a review ID."""
    ```
    
    You can tell if it is correct if you do something like:
    ```
    python
    import apply-reviews
    print review_url.__doc__
    ```



support/apply-reviews.py (line 18)
<https://reviews.apache.org/r/38705/#comment158070>

    s/JSON-ifyed/JSON-ified/


- Joseph Wu


On Sept. 26, 2015, 7:02 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message