mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.
Date Fri, 25 Sep 2015 23:16:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38756/#review100714
-----------------------------------------------------------


For me, `mkdir build && cd build && cmake .. && make`.

Gave me an error (OSX):

```
Scanning dependencies of target mesos-0.25.0
/Applications/Xcode.app/Contents/Developer/usr/bin/make -f src/CMakeFiles/mesos-0.25.0.dir/build.make
src/CMakeFiles/mesos-0.25.0.dir/build
/usr/local/Cellar/cmake/3.2.3/bin/cmake -E cmake_progress_report /Users/josephwu/mesos2/build-cmake/CMakeFiles


...

[ 77%] Building CXX object src/CMakeFiles/mesos-0.25.0.dir/slave/http.cpp.o
cd /Users/josephwu/mesos2/build-cmake/src && /usr/local/bin/c++   -DLIBDIR=\"WARNINGDONOTUSEME\"
-DPICOJSON_USE_INT64 -DPKGLIBEXECDIR=\"WARNINGDONOTUSEME\" -DVERSION=\"WARNINGDONOTUSEME\"
-D__STDC_FORMAT_MACROS -std=c++11 -g -I/Users/josephwu/mesos2/include -I/Users/josephwu/mesos2/include/mesos
-I/Users/josephwu/mesos2/build-cmake/include -I/Users/josephwu/mesos2/build-cmake/src -I/Users/josephwu/mesos2/src
-I/Users/josephwu/mesos2/3rdparty/libprocess/3rdparty/../include -I/Users/josephwu/mesos2/3rdparty/libprocess/3rdparty/stout/include
-I/Users/josephwu/mesos2/build-cmake/3rdparty/libprocess/3rdparty/boost-1.53.0/src/boost-1.53.0
-I/Users/josephwu/mesos2/build-cmake/3rdparty/libprocess/3rdparty/glog-0.3.3/src/glog-0.3.3-lib/lib/include
-I/Users/josephwu/mesos2/build-cmake/3rdparty/libprocess/3rdparty/picojson-1.3.0/src/picojson-1.3.0
-I/Users/josephwu/mesos2/build-cmake/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protobuf-2.5.0-lib/lib/include
-I/Users/josephwu/mesos2/build-cm
 ake/3rdparty/zookeeper-3.4.5/src/zookeeper-3.4.5-lib/lib/include/zookeeper    -o CMakeFiles/mesos-0.25.0.dir/slave/http.cpp.o
-c /Users/josephwu/mesos2/src/slave/http.cpp
In file included from /Users/josephwu/mesos2/src/slave/http.cpp:25:
/Users/josephwu/mesos2/include/mesos/executor/executor.hpp:25:10: fatal error: 'executor/executor.pb.h'
file not found
#include <executor/executor.pb.h>
         ^
1 error generated.
make[2]: *** [src/CMakeFiles/mesos-0.25.0.dir/slave/http.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/mesos-0.25.0.dir/all] Error 2
make: *** [all] Error 2
```

I wonder if the macro change broke something.

- Joseph Wu


On Sept. 25, 2015, 3:14 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38756/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 3:14 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3385
>     https://issues.apache.org/jira/browse/MESOS-3385
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add support for compiling the agent with CMake.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
>   src/CMakeLists.txt PRE-CREATION 
>   src/cmake/MesosProtobuf.cmake PRE-CREATION 
>   src/slave/cmake/AgentConfigure.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38756/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message