mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38777: Avoid closing '-1' file descriptors in Subprocess.
Date Fri, 25 Sep 2015 22:24:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38777/#review100697
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Sept. 25, 2015, 10:14 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38777/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 10:14 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> close here can be called with some fds equal to -1
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 5ff784878e636c6a83db2633c2c16a4ed93d7879 
> 
> Diff: https://reviews.apache.org/r/38777/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message