mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Review Request 38734: Cleaned up function signatures to use Option<T>.
Date Thu, 24 Sep 2015 21:27:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38734/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Also make use of delegating constructors to reduce redundancy in the master
detector and master contender.


Diffs
-----

  src/master/contender.hpp 927601c73f3ba56cafb366502a5f58a71c581837 
  src/master/contender.cpp 67562f19754bd57e293b62d0b7547ff2e6cf18ad 
  src/master/detector.hpp d31ce532e0b26569e521b21893ef91d771fc20bc 
  src/master/detector.cpp d0d10e58cc32f5ba9da1bd35a66dcbf66665c204 
  src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 

Diff: https://reviews.apache.org/r/38734/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message