mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <>
Subject Re: Review Request 38645: Fixed Flaky Executor HTTP tests
Date Tue, 22 Sep 2015 20:46:21 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 22, 2015, 8:46 p.m.)

Review request for mesos, Isabel Jimenez and Vinod Kone.

Repository: mesos

Description (updated)

This showed up on ASF CI. From the logs:

`I0922 17:31:49.819221 28463 slave.cpp:4104] Finished recoveryā€¯`
Then ....
`../../src/tests/executor_http_api_tests.cpp:290: Failure`
`Failed to wait 15secs for __recover`

Instead of doing a `FUTURE_DISPATCH` after `StartSlave()` we should be doing it before starting
the slave. In some cases, slave would have already recovered by the time we invoke `FUTURE_DISPATCH`
leading to the flakiness.


  src/tests/executor_http_api_tests.cpp 9dbc5191b5950df2faa693720f3740e97c7df758 


Testing (updated)

I was not able to reproduce it before or after this change but looking at the logs it is quite
obvious what the issue was. Ran in a loop 100 times.

ASF CI error log:,CONFIGURATION=--verbose,OS=ubuntu%3A14.04,label_exp=docker%7C%7CHadoop/839/changes


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message