mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38625: Replace clone system call with os::clone
Date Tue, 22 Sep 2015 19:01:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100050
-----------------------------------------------------------

Ship it!



src/tests/containerizer/ns_tests.cpp (lines 169 - 171)
<https://reviews.apache.org/r/38625/#comment157141>

    Maybe
    
    ```
    pid_t pid = os::clone(
        lambda::bind(&childGetns, NULL),
        nstype.get() | SIGCHLD);
    ```



src/tests/containerizer/ns_tests.cpp (lines 223 - 225)
<https://reviews.apache.org/r/38625/#comment157142>

    Ditto.


- Jie Yu


On Sept. 22, 2015, 6:52 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael Park, and
Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26

>   src/tests/containerizer/launch_tests.cpp dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> -------
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message