mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38632: Fix printing of JSON numbers to be valid JSON for web browsers.
Date Tue, 22 Sep 2015 17:58:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38632/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 10:58 a.m.)


Review request for mesos, Artem Harutyunyan, Isabel Jimenez, and Joris Van Remoortere.


Summary (updated)
-----------------

Fix printing of JSON numbers to be valid JSON for web browsers.


Bugs: MESOS-3490
    https://issues.apache.org/jira/browse/MESOS-3490


Repository: mesos


Description (updated)
-------

Printing an integer as a JSON double looked like "1." which is an "unterminated fractional
number".
Instead, the printed value should be "1.0".


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp e36f4b9aed50a75767d29306cb8d4974c4995156

  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 88b6147fa47ebfcb6000de5b2f0891d4438d26bf

  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 6f154cd5ab12e1d1dd64e56574d2186ae53ee66e


Diff: https://reviews.apache.org/r/38632/diff/


Testing
-------

`make check` (OSX clang 7.0)

Manual check: Opened Mesos master web UI and a browser console (Firefox).  Verified that no
JSON parsing error appeared.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message