mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 38596: Updated http::URL to be a URI-reference.
Date Tue, 22 Sep 2015 06:18:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38596/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Repository: mesos


Description
-------

This updates URL to be a URI-reference (see [RFC 3986 4.1](https://tools.ietf.org/html/rfc3986#section-4.1)),
similarly to how other http libraries store a URL in a Request object (see the go libraries
for [Request](http://golang.org/pkg/net/http/#Request) and [URL](http://golang.org/pkg/net/url/#URL)
as an example).

The motivation for this change is to enable cleanup of the http utilities in libprocess. By
storing a full URL inside the Request, we can obtain the address from the request itself,
rather than having to pass the address alongside.


Diffs
-----

  3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2 
  3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4 

Diff: https://reviews.apache.org/r/38596/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message