mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 38574: Fixed race in hook self-message loop and reenabled VerifySlaveLaunchExecutorHook test
Date Mon, 21 Sep 2015 22:38:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38574/
-----------------------------------------------------------

(Updated Sept. 21, 2015, 3:38 p.m.)


Review request for mesos, Joris Van Remoortere and Kapil Arya.


Bugs: MESOS-2226
    https://issues.apache.org/jira/browse/MESOS-2226


Repository: mesos


Description (updated)
-------

Coordinating events across the library border is hard as we want to avoid exporting additional
symbols between the test and the module code. To migitate this, the VerifySlaveLaunchExecutorHook
used a technique where it creates a libprocess actors in-place and sends a message to itself.
This can be caught by a message filter in the shared libprocess instance and the test code
can synchronize over this, to make sure certain module code was executed.

However, the in-place actor could (potentially) shutdown before the message was received (and
thus, didn't execute the filter).

This patch installs a message handler in the in-place actor and only shuts down the actors
when the message has been received.


Diffs
-----

  src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
  src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 

Diff: https://reviews.apache.org/r/38574/diff/


Testing
-------

make check (gtest_repeat=100 and gtest_shuffle=1)


Thanks,

Niklas Nielsen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message