mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Abecassis" <>
Subject Re: Review Request 38279: Enabled resources/attributes discovery
Date Sat, 19 Sep 2015 00:51:23 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 19, 2015, 12:51 a.m.)

Review request for mesos, Connor Doyle and Niklas Nielsen.


Added tests, changed the name of the hook.

Bugs: MESOS-3366

Repository: mesos


First API draft for MESOS-3366.

1) Only supports resources for now, we can add another hook for attributes with a very similar
2) The callback currently receives the full SlaveInfo structure and construct a new Resources
3) If there is multiple callbacks, each callback will see the changes made by previous callbacks
and are free to override or merge the detected resources as they see fit.

Diffs (updated)

  include/mesos/hook.hpp 2353602 
  src/examples/test_hook_module.cpp 0dc74d6 
  src/hook/manager.hpp a517c05 
  src/hook/manager.cpp 691976e 
  src/slave/slave.cpp ad710d7 
  src/tests/hook_tests.cpp b23a587 



make clean && make && make check


Felix Abecassis

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message