mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Abecassis" <felix.abecas...@gmail.com>
Subject Re: Review Request 38279: Enabled resources/attributes discovery
Date Sat, 19 Sep 2015 00:31:57 GMT


> On Sept. 14, 2015, 5:34 p.m., Connor Doyle wrote:
> > src/hook/manager.cpp, line 261
> > <https://reviews.apache.org/r/38279/diff/1/?file=1067842#file1067842line261>
> >
> >     Please add a comment describing how the order of hook execution is determined.
 e.g. order in which they appear in the modules json passed to the slave, etc.

Actually, it seems there is no predefined order right now since src/hook/manager.cpp is using
a hashmap, should I open another issue to discuss how to fix this?


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/#review98860
-----------------------------------------------------------


On Sept. 14, 2015, 5:39 p.m., Felix Abecassis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38279/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 5:39 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
>     https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> First API draft for MESOS-3366.
> 
> 1) Only supports resources for now, we can add another hook for attributes with a very
similar code.
> 2) The callback currently receives the full SlaveInfo structure and construct a new Resources
object.
> 3) If there is multiple callbacks, each callback will see the changes made by previous
callbacks and are free to override or merge the detected resources as they see fit.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp d90bacc 
>   src/examples/test_hook_module.cpp bc13a8a 
>   src/hook/manager.hpp 30d8321 
>   src/hook/manager.cpp 754c238 
>   src/slave/slave.cpp 5e5522e 
> 
> Diff: https://reviews.apache.org/r/38279/diff/
> 
> 
> Testing
> -------
> 
> make clean && make && make check
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message