mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)
Date Fri, 18 Sep 2015 00:13:47 GMT


> On Sept. 17, 2015, 9:13 p.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp, line 3733
> > <https://reviews.apache.org/r/38003/diff/2-3/?file=1064545#file1064545line3733>
> >
> >     why the change in formatting? we allow 80 char comments now?

do you mean the following comments? Unfortunately, its length is 82 if in one line.

    // If both the slaves get the same SlaveID, the re-registration would
    // fail here.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38003/#review99442
-----------------------------------------------------------


On Sept. 18, 2015, 12:13 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38003/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 12:13 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3351
>     https://issues.apache.org/jira/browse/MESOS-3351
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> __Phenomenon:__
> In some race condition, the slave was shutdown when after master failover.
> 
> __Root Cause:__
> The slave was shutdown because of duplicated SlavID: in master, the SlaveID is genereated
by masterInfo.id + "-S" + nextSlaveId; when master failover, nextSlaveId was reset to 0 and
masterInfo.id (generated by date + ip + port + pid) maybe un-changed which lead to duplicated
SlaveID. 
> 
> __Solution/Fix:__
> Generate masterInfo.id by UUID instead of "date + ip + port + pid".
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 1c4e7af 
>   src/tests/master_tests.cpp 06d74c3 
> 
> Diff: https://reviews.apache.org/r/38003/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message