mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <>
Subject Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.
Date Thu, 17 Sep 2015 19:14:47 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 17, 2015, 12:14 p.m.)

Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Timothy Chen,
and Vinod Kone.


Re-opening with fixes for g++ 4.8/4.9 on CentOS 7.  (No changes other than rebase)

Bugs: MESOS-3345

Repository: mesos


* Add TODO's for refactoring some JSON parsing in the docker code (See MESOS-3409).  Update
how the JSON::Number is used.
* Tweak some tests to match changes to JSON::Number.
* Address a TODO on one test, which used a workaround for double-precision comparison.

Diffs (updated)

  src/docker/docker.cpp c4c37cb98ef50beeae0030ac472c7bf77e10fb5e 
  src/slave/containerizer/provisioner/docker/token_manager.cpp cf52626554f5bddcbbac4d515d7dd599d269dd57

  src/tests/fault_tolerance_tests.cpp 061e0998239f7b69d989523e341881cd4abfcdeb 
  src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b 
  src/tests/monitor_tests.cpp f4049553d9f2b0e6419d9e6f88d3b0a54184f88d 
  src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
  src/tests/slave_tests.cpp 4a1a586f645424e30a4e989d1fd2f0bc2993b188 


Testing (updated)

`make check` (OSX | clang-6.1.0, CentOS 7.1 | g++ 4.8.3)


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message