mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
Date Thu, 17 Sep 2015 16:39:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38454/#review99400
-----------------------------------------------------------


Thanks for fixing this, but I'm wondering how this fixes the issue.
(in fact, not even what is it testing).

If you invoke `cat` without input, it will just hang there waiting on STDIN, how does this
make the test work?
(sorry for all the questions, but unfortunately I'm not familiar w/ this particular test)

Can you please add more information in the Description field?
It's pretty obvious (or it should be :) ) that a patch fixes the bug it's related to, but
what folks need to understand is: (a) what the problem was; (b) how it affected the test and
(c) what you did to fix it.

Also, how does this preserve the spirit of the test? I can fix any test by just having ASSERT(true)
:)

BTW - it's fantastic this fixed the issue and you did the repeat-cycle test!

- Marco Massenzio


On Sept. 17, 2015, 9:55 a.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38454/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 9:55 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Marco Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3293
>     https://issues.apache.org/jira/browse/MESOS-3293
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp a25ae97a519feb8ead6177da160df8a276ca15bf

> 
> Diff: https://reviews.apache.org/r/38454/diff/
> 
> 
> Testing
> -------
> 
> ./mesos-tests.sh --gtest_filter="LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=1000
--gtest_break_on_failure
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message