mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.
Date Wed, 16 Sep 2015 19:44:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38370/#review99284
-----------------------------------------------------------



src/docker/executor.cpp (lines 162 - 164)
<https://reviews.apache.org/r/38370/#comment156192>

    Was "Docker.NetworkSettings.IPAddress" in 0.24.0? If so, don't we want to deprecate this
over a release cycle? (Supporting both in the interim)


- Niklas Nielsen


On Sept. 15, 2015, 2:11 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38370/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 2:11 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Timothy Chen.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docker executor to set container IP in TaskStatus::NetworkInfo.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
>   src/tests/containerizer/docker_containerizer_tests.cpp a628922cc49b1dc8a37621a6a8b7ef6842cfb051

> 
> Diff: https://reviews.apache.org/r/38370/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message