mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.
Date Tue, 15 Sep 2015 00:05:54 GMT


> On Sept. 14, 2015, 11:38 p.m., Cong Wang wrote:
> > src/slave/containerizer/isolators/cgroups/perf_event.cpp, line 413
> > <https://reviews.apache.org/r/38382/diff/1/?file=1073178#file1073178line413>
> >
> >     s/sampling will be halted// ?

Great catch, thank you!


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38382/#review98959
-----------------------------------------------------------


On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38382/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3423
>     https://issues.apache.org/jira/browse/MESOS-3423
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See [MESOS-3423](https://issues.apache.org/jira/browse/MESOS-3423).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 7dc8b7a99074b74ade019ef4df296780650a2e4e

> 
> Diff: https://reviews.apache.org/r/38382/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message