mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <>
Subject Re: Review Request 38003: MESOS-3351 (duplicated slave id in master after master failover)
Date Sat, 05 Sep 2015 02:46:09 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 5, 2015, 2:46 a.m.)

Review request for mesos and Vinod Kone.


Address Vinod's comments

Summary (updated)

MESOS-3351 (duplicated slave id in master after master failover)

Bugs: MESOS-3351

Repository: mesos

Description (updated)

In some race condition, the slave was shutdown when after master failover.

__Root Cause:__
The slave was shutdown because of duplicated SlavID: in master, the SlaveID is genereated
by + "-S" + nextSlaveId; when master failover, nextSlaveId was reset to 0 and (generated by date + ip + port + pid) maybe un-changed which lead to duplicated

Generate by UUID instead of "date + ip + port + pid".

Diffs (updated)

  src/master/master.cpp 5589eca 
  src/tests/master_tests.cpp 8a6b98b 



make check


Klaus Ma

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message