mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37814: Added documentation for libprocess environment variables
Date Mon, 31 Aug 2015 21:45:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37814/#review97156
-----------------------------------------------------------

Ship it!


Looks good! Thanks for the documentation Greg!


docs/configuration.md (line 1499)
<https://reviews.apache.org/r/37814/#comment152922>

    Can we change the style of this to be italicized instead like "These options can be supplied
to both masters and slaves." under `Master and Slave Options`?
    
    I think it makes more sense, as this sentence is a description rather than a subheading.



docs/configuration.md (line 1505)
<https://reviews.apache.org/r/37814/#comment152923>

    Below in the `Some influential environment variables for configure script:` section we
list environment variables as `Flags`. Do we maybe want to keep it consistent?


- Michael Park


On Aug. 28, 2015, 10:25 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37814/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 10:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and haosdent huang.
> 
> 
> Bugs: MESOS-2466
>     https://issues.apache.org/jira/browse/MESOS-2466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for libprocess environment variables
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 2b23d48c8841e43e6e2776dfe6bfa7c022a941a7 
> 
> Diff: https://reviews.apache.org/r/37814/diff/
> 
> 
> Testing
> -------
> 
> Built the updated website using the docker site builder (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message