mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 37197: Docker image store.
Date Mon, 31 Aug 2015 20:09:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/#review97095
-----------------------------------------------------------



src/slave/containerizer/provisioners/docker/store.cpp (line 131)
<https://reviews.apache.org/r/37197/#comment152833>

    For local store I don't think this comment is valid.
    Should just comment that only local images with file:// is supported.



src/slave/containerizer/provisioners/docker/store.cpp (line 150)
<https://reviews.apache.org/r/37197/#comment152836>

    does path::join return a Try? I was curious about this of what kind of error can it come
back with, and I think it actually just returns a String.



src/slave/containerizer/provisioners/docker/store.cpp (line 192)
<https://reviews.apache.org/r/37197/#comment152837>

    I think path::join just returns a string



src/slave/containerizer/provisioners/docker/store.cpp (line 247)
<https://reviews.apache.org/r/37197/#comment152841>

    If tar is terminated in the middle, will this operation succeed again? We only check the
directory exist to signal that we untarred the layer, but it might not necessarily really
finished.
    I Think we will have to do a mv here as well


- Timothy Chen


On Aug. 27, 2015, 11:39 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37197/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 11:39 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, and Timothy
Chen.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stored images currently kept indefinitely.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
> 
> Diff: https://reviews.apache.org/r/37197/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message