mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 37703: Add docker exec command.
Date Sat, 29 Aug 2015 13:50:45 GMT


> On Aug. 26, 2015, 4:28 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 1077
> > <https://reviews.apache.org/r/37703/diff/1/?file=1047969#file1047969line1077>
> >
> >     In what situation would we want to enable tty?

I think not need enable tty. At first I just try to follow docker exec doucment. Now I think
we could remove tty and detach here.


> On Aug. 26, 2015, 4:28 p.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 1091
> > <https://reviews.apache.org/r/37703/diff/1/?file=1047969#file1047969line1091>
> >
> >     I'm not sure this is needed since we already want to wrap the command in shell
anyways

If execute docker exec container_name "echo foo", docker would return error that could not
find command "echo foo". If execute docker exec container_name echo foo, it could works well.
So I add "sh -c" here.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review96540
-----------------------------------------------------------


On Aug. 22, 2015, 6:02 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2015, 6:02 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3291
>     https://issues.apache.org/jira/browse/MESOS-3291
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add docker exec command.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
>   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
>   src/tests/containerizer/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc 
> 
> Diff: https://reviews.apache.org/r/37703/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message