mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 37900: Maintenance Primitives: Add helper functions for the maintenance protobufs.
Date Fri, 28 Aug 2015 20:10:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37900/#review96913
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37655, 36321, 36571, 37314, 37900]

All tests passed.

- Mesos ReviewBot


On Aug. 28, 2015, 7:15 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37900/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 7:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van
Remoortere, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This includes helpers for constructing (used in tests) and for validation (used in HTTP
endpoints).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/common/protobuf_utils.hpp 63eeb77da5e6020085b9927ce15338aa6ed00488 
>   src/common/protobuf_utils.cpp 6b283558b5ef5c16f1d9f3dc2639df4f75c92f7d 
>   src/master/maintenance.hpp PRE-CREATION 
>   src/master/maintenance.cpp PRE-CREATION 
>   src/master/registrar.hpp c6a0655c212646618d93c9c85918af482a9ffd50 
> 
> Diff: https://reviews.apache.org/r/37900/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message