mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 37427: Docker registry: adding TokenManager.
Date Fri, 28 Aug 2015 00:18:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review96752
-----------------------------------------------------------



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 69)
<https://reviews.apache.org/r/37427/#comment152392>

    is exp and nbf web token fields?



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 77)
<https://reviews.apache.org/r/37427/#comment152391>

    Why keep raw?



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 223)
<https://reviews.apache.org/r/37427/#comment152457>

    Is there a reason you need to include this in the header? Can we just put it in cpp?



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 78)
<https://reviews.apache.org/r/37427/#comment152458>

    Captialize first word (Invalid), same as other error messages below.



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 164)
<https://reviews.apache.org/r/37427/#comment152460>

    Kill space



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 165)
<https://reviews.apache.org/r/37427/#comment152464>

    Shouldn't this return true?



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 203)
<https://reviews.apache.org/r/37427/#comment152462>

    We usually name the class variable without _, and the parameter with _.



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 341)
<https://reviews.apache.org/r/37427/#comment152465>

    End comment with period.


- Timothy Chen


On Aug. 26, 2015, 1:03 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37427/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes:
>   - Added Token implementation (RFC 7519).
>   - Added TokenManager implementation. This component keeps a cache of tokens
>   requested for any future requests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37427/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message