mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <>
Subject Re: Review Request 37821: Join threads in libprocess when shutting down.
Date Thu, 27 Aug 2015 22:59:13 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 27, 2015, 10:59 p.m.)

Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and switched to 'mcypark'.


Fixed race condition and moved thread initialization into ProcessManager.

Bugs: MESOS-3158

Repository: mesos


Join threads in libprocess when shutting down.

Diffs (updated)

  3rdparty/libprocess/src/event_loop.hpp 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 
  3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 
  3rdparty/libprocess/src/libevent.cpp d7c47fbd1dbdec1fc974840e6f3a1428a8f189d5 
  3rdparty/libprocess/src/process.cpp 755187c8761137cb2bf2f7295b29a63f63c68bc6 


Testing (updated)

After configuring with both "../configure" and "../configure --enable-libevent --enable-ssl":

make check

Also, to check for race conditions related to the initialization/shutdown of libprocess, try
something like:

for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests --gtest_filter=ProcessTest.Spawn;


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message