mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 37497: Added Docker provisioner paths which handles path manipulation.
Date Thu, 27 Aug 2015 22:38:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/#review96780
-----------------------------------------------------------


Bad patch!

Reviews applied: [37196, 37197, 37198, 37200]

Failed command: ./support/apply-review.sh -n -r 37200

Error:
 2015-08-27 22:38:32 URL:https://reviews.apache.org/r/37200/diff/raw/ [28082/28082] ->
"37200.patch" [1]
37200.patch:457: trailing whitespace.
          return Failure("Untar image failed with exit code: " + 
warning: 1 line adds whitespace errors.
Successfully applied: Refactored DockerImage struct to store a list of layer ids instead of
linked list of DockerLayers.

Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.


Review: https://reviews.apache.org/r/37200
src/slave/containerizer/provisioners/docker/store.cpp:184: trailing whitespace.
+          return Failure("Untar image failed with exit code: " + 
Failed to commit patch

- Mesos ReviewBot


On Aug. 27, 2015, 9:57 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37497/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 9:57 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, Timothy
Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Docker provisioner paths which handles path manipulation.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37497/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> ./bin/mesos-tests.sh --gtest_filter="*DockerProvisioner*" --gtest_repeat=20 --gtest_shuffle=1
> 
> 
> Thanks,
> 
> Lily Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message