mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover
Date Thu, 27 Aug 2015 21:24:16 GMT


> On Aug. 24, 2015, 11:56 p.m., Vinod Kone wrote:
> > This review is a bit hard to follow because it's doing multiple things. I would
recommend you to split this into multiple reviews
> > 
> > #1) Expose framework user in state.json
> > #2) Update framework user on re-registration (need a test for this!)
> 
> Aditi Dixit wrote:
>     Added the test. How do I split this into multiple reviews? Discard this one and open
two new ones by shifting the code into new branches and then opening review requests?
> 
> Joseph Wu wrote:
>     You could:
>     ```
>     # To update this review into the first in a review chain:
>     git branch temp # Save your work.
>     <Delete part of your changes> # i.e. the re-registration stuff.
>     git add --update
>     git commit --amend
>     
>     # For the second review:
>     git checkout temp -- . # Restore everything you deleted into a second commit.
>     git commit
>     
>     support/post-reviews.py
>     ```

Thanks Joseph for the workflow tip. I typically do splits a little differently.

$ git reset HEAD~
$ git add -p  # Selectively add chunks of a file(s) to the index!
$ git commit -m "First review"  # Make sure to add the "Review: <blah>" line if you
want the current review to be updated
$ git add -a # Add the rest of the changes to the index
$ git commit -m "Second review"

I'll take a look once you split and update.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96240
-----------------------------------------------------------


On Aug. 25, 2015, 8:25 p.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37500/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 8:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3240
>     https://issues.apache.org/jira/browse/MESOS-3240
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added user to master's state, slave's state (not exposed) and updated user in all slaves
that have the registered framework. Added the test too.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
>   src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 
>   src/slave/slave.cpp 2a99abc00c525a93508d38e74d351d2f36572d86 
>   src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/slave_tests.cpp d55e9dd4f4eb84a8fda85439e31a38e70890b377 
> 
> Diff: https://reviews.apache.org/r/37500/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message