mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.
Date Thu, 27 Aug 2015 20:54:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96746
-----------------------------------------------------------

Ship it!



include/mesos/maintenance/maintenance.proto (line 54)
<https://reviews.apache.org/r/36571/#comment152384>

    How about we move Mode into MachineInfo so that we can use this as a property of machines
regardless of whether or not we're doing maintenance? I.e., MachineInfo::DRAINING.



include/mesos/mesos.proto (line 127)
<https://reviews.apache.org/r/36571/#comment152382>

    This stuff also needs to go into v1 please!



src/master/registry.proto (line 43)
<https://reviews.apache.org/r/36571/#comment152385>

    If we ever want to capture non-maintenance information about machines here I'd recommend
that we s/MaintenanceStatus/MachineStatus/, and for now with only one field ('machine_info')
that we might add to later. Meanwhile, we can move 'mode' into MachineInfo and make the current
MachineInfo be a MachineID ...


- Benjamin Hindman


On Aug. 27, 2015, 7:33 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 7:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van
Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
>     https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * MachineInfo - Describes a single box that holds one or more agents.
> * MachineInfos - A list of boxes.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> * maintenance::Mode - An enum for the three states of maintenance: Normal, Draining,
Deactivated.
> * Registry::MaintenanceStatus - Holds the maintenance mode of a machine.
> 
> 
> Diffs
> -----
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message