mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 37427: Docker registry: adding TokenManager.
Date Thu, 27 Aug 2015 14:43:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review96685
-----------------------------------------------------------



src/tests/provisioners/docker_provisioner_tests.cpp (lines 52 - 82)
<https://reviews.apache.org/r/37427/#comment152306>

    *IF* we can't generalize the SSL testing class (comment below), then let's move openssl_util.hpp
into the libprocess public headers instead so we don't have to do this.



src/tests/provisioners/docker_provisioner_tests.cpp (lines 229 - 231)
<https://reviews.apache.org/r/37427/#comment152307>

    Can you pull `SSLTest` out of `ssl_tests.cpp` into an accessible place so you can re-use
it?
    I think this is worth it right now.


- Joris Van Remoortere


On Aug. 26, 2015, 1:03 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37427/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 1:03 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes:
>   - Added Token implementation (RFC 7519).
>   - Added TokenManager implementation. This component keeps a cache of tokens
>   requested for any future requests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37427/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message