mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 37364: Maintenance Primitives: Adds an endpoint for retrieving the maintenance status for machines.
Date Wed, 26 Aug 2015 22:44:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37364/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 3:44 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere,
and Vinod Kone.


Changes
-------

Updated to match comments and changes from previous reviews.


Bugs: MESOS-2067
    https://issues.apache.org/jira/browse/MESOS-2067


Repository: mesos


Description
-------

Endpoint: /maintenance.status

Returns a JSON object like:
```
{
  "draining": [
    { "hostname": "foo", "ip": "0.0.0.1" },
    { "hostname": "bar", "ip": "0.0.0.2" },
  ],
  "deactivated": [
    { "hostname": "baz", "ip": "0.0.0.3" },
  ]
}
```


Diffs (updated)
-----

  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37364/diff/


Testing
-------

`make check`

New Tests:
  MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines
    Extra test case for the /maintenance.schedule endpoint, which requires all three endpoints
to work.
  MasterMaintenanceTest.MachineStatus
    Schedules, starts, and stops maintenance.  Checks machine statuses after each step.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message