mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 37358: Maintenance Primitives: Adds an endpoint for transitioning agents into the Deactivated maintenance mode.
Date Tue, 25 Aug 2015 16:14:16 GMT


> On Aug. 25, 2015, 1:36 a.m., Guangya Liu wrote:
> > src/master/maintenance.cpp, line 121
> > <https://reviews.apache.org/r/37358/diff/5/?file=1048624#file1048624line121>
> >
> >     What does strict means here? I see it was not used

This is explained in the previous review: https://reviews.apache.org/r/37325/diff/11#6

Essentially, this is the `registry_strict` flag, which only applies to operations which affect
masters/agents infos in the registry.  Hence, we do not use it for maintenance.


> On Aug. 25, 2015, 1:36 a.m., Guangya Liu wrote:
> > src/master/maintenance.cpp, line 133
> > <https://reviews.apache.org/r/37358/diff/5/?file=1048624#file1048624line133>
> >
> >     Not quite understand the logic here, what does "changed" means? If one machine
put into DEACTIVATED mode, then the changed will be translated to true and it will be true
for the whole life cycle of this function.

This is to satisfy the prototype of an Operation.  `Operation::perform` returns a bool indicating
if the registry was changed as a result of the operation.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37358/#review96309
-----------------------------------------------------------


On Aug. 24, 2015, 11:54 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37358/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 11:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van
Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2067 and MESOS-3069
>     https://issues.apache.org/jira/browse/MESOS-2067
>     https://issues.apache.org/jira/browse/MESOS-3069
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Endpoint: /maintenance.start
> 
> Registry operation = maintenance::StartMaintenance
>   Sets the list of machines as Deactivated.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
>   src/master/maintenance.hpp PRE-CREATION 
>   src/master/maintenance.cpp PRE-CREATION 
>   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/tests/master_maintenance_tests.cpp PRE-CREATION 
>   src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 
> 
> Diff: https://reviews.apache.org/r/37358/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> New Tests:
>   RegistrarTest.StartMaintenance
>     Schedules some machines.  Deactivates some.
>   MasterMaintenanceTest.StartMaintenance
>     Tests some invalid lists.
>     Schedules some machines.  Tests some valid and invalid lists.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message