mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.
Date Tue, 25 Aug 2015 01:38:14 GMT


> On Aug. 18, 2015, 9:33 p.m., Joseph Wu wrote:
> > src/master/master.hpp, line 478
> > <https://reviews.apache.org/r/37175/diff/3/?file=1043316#file1043316line478>
> >
> >     Why is this return type `Nothing`, instead of `void`?

It was `Nothing` as I was calling this function from the tests before. It needed to be `Nothing`
for `dispatch` to work as `Future<void>` is invalid. This is no longer necessary due
to your helper functions.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review95783
-----------------------------------------------------------


On Aug. 18, 2015, 6:57 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629

>   src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b 
>   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/tests/master_maintenance_tests.cpp PRE-CREATION 
>   src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c 
> 
> Diff: https://reviews.apache.org/r/37175/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message