mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.
Date Tue, 25 Aug 2015 00:57:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96259
-----------------------------------------------------------



include/mesos/mesos.proto (line 125)
<https://reviews.apache.org/r/36321/#comment151594>

    Unavailability is a time interval or period, but from the name of "Unavailability", someone
may not able to understand it specifies the time interval or period for maintain. What about
using name "UnavailableInterval" or "UnavailablePeriod" which might be more meaningful?



include/mesos/mesos.proto (line 914)
<https://reviews.apache.org/r/36321/#comment151597>

    s/(i.e. which slave)/(i.e. which framework)
    
    I think that the comments for this may need to be updated as here if no framework id is
specified, then all framework's resources will be request back.



include/mesos/mesos.proto (line 939)
<https://reviews.apache.org/r/36321/#comment151598>

    Can you please elaborate more for why "in maintaince purpose, this field is always empty"?
Why cannot an operator set the resources that s/he want to inverse?


- Guangya Liu


On 八月 24, 2015, 6:26 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> -----------------------------------------------------------
> 
> (Updated 八月 24, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van
Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
>     https://issues.apache.org/jira/browse/MESOS-2061
>     https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> No integration with other components (that part is tracked in separate JIRAs, see MESOS-1474).
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message