mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.
Date Tue, 25 Aug 2015 00:01:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96244
-----------------------------------------------------------

Ship it!


Ship It!


include/mesos/mesos.proto (line 98)
<https://reviews.apache.org/r/37655/#comment151584>

    Can you expand the comment to make it clean that nanoseconds is the remainder, not a more
precise representation of the full amount of time.


- Joris Van Remoortere


On Aug. 20, 2015, 5:03 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 5:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere,
and Vinod Kone.
> 
> 
> Bugs: MESOS-3299
>     https://issues.apache.org/jira/browse/MESOS-3299
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
> 
> This will be important if frameworks need to compare times to make decisions (such as
for maintenance primitives).
> 
> Note about the naming:
> 
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
> 
> Diff: https://reviews.apache.org/r/37655/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message