mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 37362: Maintenance Primitives: Adds an endpoint for transitioning agents back into Normal mode.
Date Mon, 24 Aug 2015 19:08:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/
-----------------------------------------------------------

(Updated Aug. 24, 2015, 12:08 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere,
and Vinod Kone.


Changes
-------

Rebased and updated diff.  No other changes.


Bugs: MESOS-2067 and MESOS-3069
    https://issues.apache.org/jira/browse/MESOS-2067
    https://issues.apache.org/jira/browse/MESOS-3069


Repository: mesos


Description
-------

Endpoint: /maintenance.stop

Registry operation = maintenance::StopMaintenance
  Sets the list of machines back to Normal mode.  Removes those machines from the maintenance
schedule.


Diffs (updated)
-----

  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/master/maintenance.hpp PRE-CREATION 
  src/master/maintenance.cpp PRE-CREATION 
  src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 
  src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 

Diff: https://reviews.apache.org/r/37362/diff/


Testing
-------

`make check`

New Tests:
  RegistrarTest.StopMaintenance
    Schedules some machines.  Deactivates some.  Reactivates some.
  MasterMaintenanceTest.ReactivateMachines
    Tests some invalid lists.
    Schedules some machines.  Deactivates some.  Tests some valid and invalid lists.
    Checks that the schedule is modified.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message