mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lily Chen" <l...@mesosphere.io>
Subject Re: Review Request 37197: Docker image store.
Date Mon, 24 Aug 2015 18:49:31 GMT


> On Aug. 19, 2015, 6:11 a.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/docker/store.cpp, line 1
> > <https://reviews.apache.org/r/37197/diff/6/?file=1041380#file1041380line1>
> >
> >     Btw this is actually renamed to be local store later right?
> >     
> >     How about just remove the impl completely in this review so later review we
introduce the local store?

Squashed commit that moves store implementation to LocalStore into this commit.


- Lily


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/#review95830
-----------------------------------------------------------


On Aug. 19, 2015, 6:41 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37197/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2015, 6:41 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stored images currently kept indefinitely.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
> 
> Diff: https://reviews.apache.org/r/37197/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message