mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <>
Subject Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.
Date Mon, 24 Aug 2015 18:48:49 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 24, 2015, 11:48 a.m.)

Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere,
and Vinod Kone.


Rebased and updated diff.  No other changes.

Bugs: MESOS-2067 and MESOS-3069

Repository: mesos


Endpoint: /maintenance.schedule

Registry operation = maintenance::UpdateSchedule
  Replaces the schedule with the given one.  Also sets all scheduled machines into Draining

Other changes:
  Added a note about the "strict" flag.

Diffs (updated)

  src/ 9fd71d1ddf442712977596e7a13969ff5c1d68db 
  src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 
  src/master/maintenance.hpp PRE-CREATION 
  src/master/maintenance.cpp PRE-CREATION 
  src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/master/registrar.hpp c6a0655c212646618d93c9c85918af482a9ffd50 
  src/tests/maintenance.hpp PRE-CREATION 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 
  src/tests/registrar_tests.cpp 032e644ee19751b4ce5767d46f474d34ec4b9166 



`make check`

New Tests:
    Schedules 3 machines, 1 at a time.  Rearranges schedules.
    Checks that machines are put into Draining mode.  Removes machines.
    Hits the new endpoint with some valid and invalid schedules.
    Only tests a subset of invalid schedules (requires other endpoints to fully test).


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message