mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 37532: Add QUIESCE call interface to the scheduler
Date Sat, 22 Aug 2015 14:26:22 GMT


> On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote:
> > include/mesos/scheduler/scheduler.proto, lines 314-315
> > <https://reviews.apache.org/r/37532/diff/1/?file=1042006#file1042006line314>
> >
> >     This comments does not read well: what is the timeout? also, it would be good
to have a bit of info about what the filters are
> >     
> >     (eg, are they 'inclusion' or 'exclusion' filters? etc.)

Marco, can you pls show more the difference between "inclusion" and "exclusion" filters? I'm
not quite catch this point. Thanks.


> On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote:
> > src/tests/scheduler_tests.cpp, line 1003
> > <https://reviews.apache.org/r/37532/diff/1/?file=1042011#file1042011line1003>
> >
> >     so, this is a good test, but I would really like to see one where we ask Master
to keep quiet for a while and we don't get offers during that period of time, then we start
getting again.
> >     
> >     It may require some fiddling around with `Clock`s and all that jazz, but it
would give us more confidence that this whole thing works.
> >     
> >     Also - some tests around more complex filtering (if any? maybe this is there
is, then it's fine).

I'm planning to add more test cases in another patch, make sense? Thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95997
-----------------------------------------------------------


On 八月 17, 2015, 1:47 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> -----------------------------------------------------------
> 
> (Updated 八月 17, 2015, 1:47 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55

>   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
>   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message