mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <>
Subject Re: Review Request 37336: Simplified the caller interface to process::Subprocess
Date Thu, 20 Aug 2015 08:03:48 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 20, 2015, 8:03 a.m.)

Review request for mesos and Joris Van Remoortere.


This now works and passes a sensible set of tests; still, there is some 'surprising' behavior
and I'd like to understand that before committing.

Summary (updated)

Simplified the caller interface to process::Subprocess

Bugs: MESOS-3035

Repository: mesos

Description (updated)

Jira: MESOS-3035

The original API for `process::Subprocess` still left a lot of legwork
to do for the caller; we have now added a `wait(Duration timeout)` method
that returns a `CommandResult` (also introduced with this patch) which
contains useful information about the command invocation; the exit code;
stdout and, optionally, stderr too.

The `wait()` method will wait for both the process to terminate, and
stdout/stderr to be available to read from; it also "unpacks" them into
ready-to-use `string`s.

Diffs (updated)

  3rdparty/libprocess/include/process/subprocess.hpp d2341a53aac7c779668ee80983f73158fd44bff5

  3rdparty/libprocess/src/subprocess.cpp d6ea62ed1c914d34e0e189395831c86fff8aac22 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d



make check


Marco Massenzio

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message