mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 37556: Updated base64::decode to reject forbidden characters.
Date Mon, 17 Aug 2015 22:49:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37556/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-3284
    https://issues.apache.org/jira/browse/MESOS-3284


Repository: mesos


Description
-------

`base64::decode` should return a Try to capture that invalid characters cannot be decoded.

Note that base64:: could use some refactoring for clarity.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 110cb49fe0a1306cfa8eeee1ffe7b542f75d69b7

  3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp ff3d31b0ba748ae3dd346d1b70231cbaabd3189a


Diff: https://reviews.apache.org/r/37556/diff/


Testing
-------

Updated the test, note that this still misses validation of the padding suffix.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message