mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.
Date Wed, 12 Aug 2015 21:16:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180/#review95172
-----------------------------------------------------------


Why are the InverseOffers (and Offers) hashed as pointers?


src/master/master.cpp (lines 4795 - 4796)
<https://reviews.apache.org/r/37180/#comment150011>

    This second sentence might be better placed in the InverseOffer protobuf.



src/master/master.cpp (line 5667)
<https://reviews.apache.org/r/37180/#comment150014>

    `callled`


- Joseph Wu


On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37180/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3 
>   src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
> 
> Diff: https://reviews.apache.org/r/37180/diff/
> 
> 
> Testing
> -------
> 
> The tests break as expected.
> With the scheduler API change there are CHECKs that fail.
> Once we update the API these will be resolved.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message