mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 37378: Updated http api tests to use V1 Protobufs
Date Wed, 12 Aug 2015 03:17:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37378/#review95056
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37082, 37192, 37378]

All tests passed.

- Mesos ReviewBot


On Aug. 12, 2015, 12:14 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37378/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 12:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated to use v1 protobufs for http api tests. Added a default conversion function for
FrameworkInfo in devolve()
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.hpp b9a854a5e2454a4c3f2b85032b928b2cbc0b000c 
>   src/internal/devolve.cpp be74a26e9a194a8d969c667fdc084964939dfdb7 
>   src/tests/http_api_tests.cpp 23214dfc770d9b18c85ddbdaf35b85e59eeb8acf 
> 
> Diff: https://reviews.apache.org/r/37378/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message