mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 37133: Add a frameworks parameter to the hierarchical allocator benchmark.
Date Wed, 12 Aug 2015 00:39:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37133/#review95027
-----------------------------------------------------------

Ship it!


Sorry this took so long, I'll get this committed for you now.


src/tests/hierarchical_allocator_tests.cpp (line 1119)
<https://reviews.apache.org/r/37133/#comment149806>

    This comment seems a bit misleading, since each slave only has allocation for 1 framework.
I'll re-phrase it.


- Ben Mahler


On Aug. 5, 2015, 5:34 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37133/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 5:34 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3209
>     https://issues.apache.org/jira/browse/MESOS-3209
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Parameterize the hierarchical allocator benchmark by the framework
> count as well as the slave count. This can be used to explore
> allocation behavior as the number of frameworks increases.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp c92d47aa0a06088f1f8fe749a629c27bfadd3c6d

> 
> Diff: https://reviews.apache.org/r/37133/diff/
> 
> 
> Testing
> -------
> 
> make check
> make bench
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message