mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 37335: Fixed scheduler library tests after moving to http
Date Tue, 11 Aug 2015 19:12:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37335/#review94976
-----------------------------------------------------------



src/tests/scheduler_tests.cpp (lines 168 - 170)
<https://reviews.apache.org/r/37335/#comment149715>

    IIUC, sending a subscribe call closes the previous reader/stream. How come it receives
an error event on the new stream?


- Vinod Kone


On Aug. 11, 2015, 5:40 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37335/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 5:40 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-2552
>     https://issues.apache.org/jira/browse/MESOS-2552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We now let the original scheduler know if some other instance of it failed over. Fixed
a test to ignore this error event.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 3f01c060045b36b90d027ea3ecfef887ee5f145f 
> 
> Diff: https://reviews.apache.org/r/37335/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message