mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.
Date Tue, 11 Aug 2015 18:01:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37277/#review94843
-----------------------------------------------------------


Looks pretty good, just some minor things.


src/master/master.hpp (line 1288)
<https://reviews.apache.org/r/37277/#comment149502>

    &?



src/master/master.hpp (line 1290)
<https://reviews.apache.org/r/37277/#comment149501>

    Why is this an Option? Seems like it is required for this.



src/master/master.hpp (line 1302)
<https://reviews.apache.org/r/37277/#comment149674>

    Might want to add the 'override' keyword now that we have C++11, the compiler will make
sure that we're actually overriding :)



src/master/master.hpp (lines 1606 - 1622)
<https://reviews.apache.org/r/37277/#comment149678>

    Shouldn't we start the heartbeater once we set the http connection? Otherwise we're starting
one with a None connection.
    
    That would avoid the need for the CHECK_SOME / dispatch to `update` as well. We should
probably just remove update, and do stop/start instead.



src/master/master.hpp (line 1630)
<https://reviews.apache.org/r/37277/#comment149679>

    Response header or SUBSCRIBED?



src/master/master.hpp (lines 1715 - 1716)
<https://reviews.apache.org/r/37277/#comment149680>

    Any reason to avoid Owned?


- Ben Mahler


On Aug. 9, 2015, 8:31 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37277/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2015, 8:31 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-3131
>     https://issues.apache.org/jira/browse/MESOS-3131
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Just wanted to send out the abstraction for feedback.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 2e0355960c8c771f28f3ed4428cc047e5787fff7 
>   src/internal/evolve.cpp 4678d67c8324e5c15188b5454e7cc6165d22d9bc 
>   src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3 
> 
> Diff: https://reviews.apache.org/r/37277/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> No new tests have been added yet.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message