mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 37165: Introduced v1 API.
Date Sat, 08 Aug 2015 23:43:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37165/
-----------------------------------------------------------

(Updated Aug. 8, 2015, 11:43 p.m.)


Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.


Repository: mesos


Description
-------

Perhaps the right thing is to move internal/{d|e}volve.hpp|cpp to v1/{d|e}volve.hpp|cpp?

Note that Anand can fix up src/scheduler/scheduler.cpp to just use the HTTP API once it's
finished and can kill all authenticating code and 'install', 'send', 'evolve', 'devolve' code
and update src/tests/scheduler_tests.cpp as well.


Diffs (updated)
-----

  include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
  include/mesos/v1/attributes.hpp PRE-CREATION 
  include/mesos/v1/mesos.hpp PRE-CREATION 
  include/mesos/v1/mesos.proto PRE-CREATION 
  include/mesos/v1/resources.hpp PRE-CREATION 
  include/mesos/v1/scheduler.hpp PRE-CREATION 
  include/mesos/v1/scheduler/scheduler.hpp PRE-CREATION 
  include/mesos/v1/scheduler/scheduler.proto PRE-CREATION 
  include/mesos/v1/values.hpp PRE-CREATION 
  src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
  src/common/protobuf_utils.hpp 312bc61ebb612be64fc5cfbcda8dcaf9663be6c7 
  src/common/protobuf_utils.cpp 4de176b5b1d7fe71bdb895b19a90a1d9d33d37db 
  src/examples/event_call_framework.cpp 0093363ea7b70230d5cbd29599cb0f4dc8a91d68 
  src/internal/devolve.hpp PRE-CREATION 
  src/internal/devolve.cpp PRE-CREATION 
  src/internal/evolve.hpp PRE-CREATION 
  src/internal/evolve.cpp PRE-CREATION 
  src/master/contender.hpp 62bcff4aaf44936815c23f50b8066497af66fcd3 
  src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e 
  src/scheduler/scheduler.cpp a0df048bddd3f0682518eb50944895a728ec4eb7 
  src/tests/mesos.hpp 20418d4fbd2f4ae35ee0c707472cbf37125883b0 
  src/tests/scheduler_driver_tests.cpp PRE-CREATION 
  src/tests/scheduler_tests.cpp 9d29d1ab0cb2914f4749e05af95c1c21e88908ca 
  src/tests/slave_tests.cpp cb5a01ed771e66d75091ca33523dbe673e16a86e 
  src/v1/attributes.cpp PRE-CREATION 
  src/v1/mesos.cpp PRE-CREATION 
  src/v1/resources.cpp PRE-CREATION 
  src/v1/values.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37165/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message