mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 37165: Introduced v1 API.
Date Thu, 06 Aug 2015 19:39:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37165/#review94436
-----------------------------------------------------------

Ship it!


LGTM. Please rebase and let the review bot give an OK before committing.


src/Makefile.am (lines 237 - 245)
<https://reviews.apache.org/r/37165/#comment149037>

    Add a comment for why you did "-mv"?



src/Makefile.am (lines 467 - 472)
<https://reviews.apache.org/r/37165/#comment149036>

    reorder alphabetically.



src/Makefile.am (lines 852 - 855)
<https://reviews.apache.org/r/37165/#comment149038>

    alphabetical.



src/Makefile.am (lines 1158 - 1161)
<https://reviews.apache.org/r/37165/#comment149039>

    alphabetical.



src/examples/event_call_framework.cpp (line 25)
<https://reviews.apache.org/r/37165/#comment149041>

    use v1/resources.hpp



src/examples/event_call_framework.cpp (lines 239 - 242)
<https://reviews.apache.org/r/37165/#comment149042>

    use v1 resources.



src/internal/devolve.hpp (line 37)
<https://reviews.apache.org/r/37165/#comment149043>

    lets kill unused ones.



src/internal/evolve.hpp (line 39)
<https://reviews.apache.org/r/37165/#comment149044>

    kill unused ones.



src/master/master.hpp (line 1346)
<https://reviews.apache.org/r/37165/#comment149045>

    Add a comment to be more clear on what is happening here?



src/scheduler/scheduler.cpp (line 238)
<https://reviews.apache.org/r/37165/#comment149048>

    Can you add a comment somewhere that the master needs to write a v1 MasterInfo into ZK?


- Vinod Kone


On Aug. 6, 2015, 6:31 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37165/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 6:31 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Perhaps the right thing is to move internal/{d|e}volve.hpp|cpp to v1/{d|e}volve.hpp|cpp?
> 
> Note that Anand can fix up src/scheduler/scheduler.cpp to just use the HTTP API once
it's finished and can kill all authenticating code and 'install', 'send', 'evolve', 'devolve'
code and update src/tests/scheduler_tests.cpp as well.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp cd235a11e63a5df742057be8e2dddd7629db4cf9 
>   include/mesos/v1/attributes.hpp PRE-CREATION 
>   include/mesos/v1/mesos.hpp PRE-CREATION 
>   include/mesos/v1/mesos.proto PRE-CREATION 
>   include/mesos/v1/resources.hpp PRE-CREATION 
>   include/mesos/v1/scheduler.hpp PRE-CREATION 
>   include/mesos/v1/scheduler/scheduler.hpp PRE-CREATION 
>   include/mesos/v1/scheduler/scheduler.proto PRE-CREATION 
>   include/mesos/v1/values.hpp PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a 
>   src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a 
>   src/examples/event_call_framework.cpp 8054068fa746f8635f1133ceac530e04eaa0e1d7 
>   src/internal/devolve.hpp PRE-CREATION 
>   src/internal/devolve.cpp PRE-CREATION 
>   src/internal/evolve.hpp PRE-CREATION 
>   src/internal/evolve.cpp PRE-CREATION 
>   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
>   src/scheduler/scheduler.cpp 97fa2c063db506dec69ff1edd851c96b4e1219a4 
>   src/tests/mesos.hpp 93d87c78e5665b8104dbbc3d1e8c92e515cc67ab 
>   src/tests/scheduler_driver_tests.cpp PRE-CREATION 
>   src/tests/scheduler_tests.cpp 98fc70bf43ba99b54064a236795c7e1269004b71 
>   src/tests/slave_tests.cpp cb5a01ed771e66d75091ca33523dbe673e16a86e 
>   src/v1/attributes.cpp PRE-CREATION 
>   src/v1/mesos.cpp PRE-CREATION 
>   src/v1/resources.cpp PRE-CREATION 
>   src/v1/values.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37165/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message