mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <>
Subject Re: Review Request 37080: Introduced RecordIO response reader
Date Wed, 05 Aug 2015 15:31:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 5, 2015, 3:31 p.m.)

Review request for mesos, Ben Mahler and Vinod Kone.


Added the ".hpp" to the makefile ( would be needed by distcheck )

Repository: mesos


Added a decorator class over the existing Record-IO decoder in stout (MESOS-3067). The decorator
accepts a Pipe::Reader thereby abstracting away the record reading logic. The future returns
true only when it sees a complete record. This cleaned up the tests as we no longer need to
invoke the stout decoder multiple times till we got atleast one element.

Needed for MESOS-2294 testing.

Diffs (updated)

  src/ 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
  src/common/recordio_response.hpp PRE-CREATION 
  src/tests/common/recordio_response_tests.cpp PRE-CREATION 



make check + added tests.


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message